From e491bd2ee34860b14ff18abc5602f9aa5b197a2d Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 10 Mar 2015 12:26:34 -0300 Subject: Move BRIN page type to page's last two bytes ... which is the usual convention among AMs, so that pg_filedump and similar utilities can tell apart pages of different AMs. It was also the intent of the original code, but I failed to realize that alignment considerations would move the whole thing to the previous-to-last word in the page. The new definition of the associated macro makes surrounding code a bit leaner, too. Per note from Heikki at http://www.postgresql.org/message-id/546A16EF.9070005@vmware.com --- src/include/access/spgist_private.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/include/access/spgist_private.h') diff --git a/src/include/access/spgist_private.h b/src/include/access/spgist_private.h index 0492ef6114b..413f71e7298 100644 --- a/src/include/access/spgist_private.h +++ b/src/include/access/spgist_private.h @@ -64,6 +64,8 @@ typedef SpGistPageOpaqueData *SpGistPageOpaque; * which otherwise would have a hard time telling pages of different index * types apart. It should be the last 2 bytes on the page. This is more or * less "free" due to alignment considerations. + * + * See comments above GinPageOpaqueData. */ #define SPGIST_PAGE_ID 0xFF82 -- cgit v1.2.3