From 7f7f25f15edb6eacec58179ef5285e874aa4435b Mon Sep 17 00:00:00 2001 From: Thomas Munro Date: Thu, 18 Mar 2021 00:35:04 +1300 Subject: Revert "Fix race in Parallel Hash Join batch cleanup." This reverts commit 378802e3713c6c0fce31d2390c134cd5d7c30157. This reverts commit 3b8981b6e1a2aea0f18384c803e21e9391de669a. Discussion: https://postgr.es/m/CA%2BhUKGJmcqAE3MZeDCLLXa62cWM0AJbKmp2JrJYaJ86bz36LFA%40mail.gmail.com --- src/include/executor/hashjoin.h | 37 ++++++++++++++++++------------------- 1 file changed, 18 insertions(+), 19 deletions(-) (limited to 'src/include/executor') diff --git a/src/include/executor/hashjoin.h b/src/include/executor/hashjoin.h index 176fbef149e..d74034f64f8 100644 --- a/src/include/executor/hashjoin.h +++ b/src/include/executor/hashjoin.h @@ -254,32 +254,31 @@ typedef struct ParallelHashJoinState } ParallelHashJoinState; /* The phases for building batches, used by build_barrier. */ -#define PHJ_BUILD_ELECT 0 -#define PHJ_BUILD_ALLOCATE 1 -#define PHJ_BUILD_HASH_INNER 2 -#define PHJ_BUILD_HASH_OUTER 3 -#define PHJ_BUILD_RUN 4 -#define PHJ_BUILD_FREE 5 +#define PHJ_BUILD_ELECTING 0 +#define PHJ_BUILD_ALLOCATING 1 +#define PHJ_BUILD_HASHING_INNER 2 +#define PHJ_BUILD_HASHING_OUTER 3 +#define PHJ_BUILD_DONE 4 /* The phases for probing each batch, used by for batch_barrier. */ -#define PHJ_BATCH_ELECT 0 -#define PHJ_BATCH_ALLOCATE 1 -#define PHJ_BATCH_LOAD 2 -#define PHJ_BATCH_PROBE 3 -#define PHJ_BATCH_FREE 4 +#define PHJ_BATCH_ELECTING 0 +#define PHJ_BATCH_ALLOCATING 1 +#define PHJ_BATCH_LOADING 2 +#define PHJ_BATCH_PROBING 3 +#define PHJ_BATCH_DONE 4 /* The phases of batch growth while hashing, for grow_batches_barrier. */ -#define PHJ_GROW_BATCHES_ELECT 0 -#define PHJ_GROW_BATCHES_REALLOCATE 1 -#define PHJ_GROW_BATCHES_REPARTITION 2 -#define PHJ_GROW_BATCHES_DECIDE 3 -#define PHJ_GROW_BATCHES_FINISH 4 +#define PHJ_GROW_BATCHES_ELECTING 0 +#define PHJ_GROW_BATCHES_ALLOCATING 1 +#define PHJ_GROW_BATCHES_REPARTITIONING 2 +#define PHJ_GROW_BATCHES_DECIDING 3 +#define PHJ_GROW_BATCHES_FINISHING 4 #define PHJ_GROW_BATCHES_PHASE(n) ((n) % 5) /* circular phases */ /* The phases of bucket growth while hashing, for grow_buckets_barrier. */ -#define PHJ_GROW_BUCKETS_ELECT 0 -#define PHJ_GROW_BUCKETS_REALLOCATE 1 -#define PHJ_GROW_BUCKETS_REINSERT 2 +#define PHJ_GROW_BUCKETS_ELECTING 0 +#define PHJ_GROW_BUCKETS_ALLOCATING 1 +#define PHJ_GROW_BUCKETS_REINSERTING 2 #define PHJ_GROW_BUCKETS_PHASE(n) ((n) % 3) /* circular phases */ typedef struct HashJoinTableData -- cgit v1.2.3