From 977c77759c1d602237896d91d6403e5adc03ffe1 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Tue, 18 Aug 2009 21:23:21 +0000 Subject: Fix overflow for INTERVAL 'x ms' where x is more than a couple million, and integer datetimes are in use. Per bug report from Hubert Depesz Lubaczewski. Alex Hunsaker --- src/include/utils/timestamp.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/include/utils/timestamp.h') diff --git a/src/include/utils/timestamp.h b/src/include/utils/timestamp.h index 291de5cdeac..ab74d8e9cf0 100644 --- a/src/include/utils/timestamp.h +++ b/src/include/utils/timestamp.h @@ -6,7 +6,7 @@ * Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group * Portions Copyright (c) 1994, Regents of the University of California * - * $PostgreSQL: pgsql/src/include/utils/timestamp.h,v 1.80 2009/06/11 14:49:13 momjian Exp $ + * $PostgreSQL: pgsql/src/include/utils/timestamp.h,v 1.80.2.1 2009/08/18 21:23:21 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -39,6 +39,8 @@ * TimeOffset and fsec_t are convenience typedefs for temporary variables * that are of different types in the two cases. Do not use fsec_t in values * stored on-disk, since it is not the same size in both implementations. + * Also, fsec_t is only meant for *fractional* seconds; beware of overflow + * if the value you need to store could be many seconds. */ #ifdef HAVE_INT64_TIMESTAMP -- cgit v1.2.3