From a3699daea2026de324ed7cc7115c36d3499010d3 Mon Sep 17 00:00:00 2001 From: Michael Paquier Date: Tue, 19 Nov 2024 13:27:42 +0900 Subject: libpq: Improve error message when parsing URI parameters and keywords The error message showing up when parameters or keywords include too many whitespaces was "trailing data found", which was confusing because there was no hint about what was actually wrong. Issue introduced in 430ce189fc45, hence there is no need for a backpatch. Author: Yushi Ogiwara Reviewed-by: Fujii Masao, Tom Lane, Bruce Momjian Discussion: https://postgr.es/m/645bd22a53c4da8a1bc7e1e52d9d3b52@oss.nttdata.com --- src/interfaces/libpq/fe-connect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'src/interfaces/libpq/fe-connect.c') diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c index 51083dcfd8e..aaf87e8e885 100644 --- a/src/interfaces/libpq/fe-connect.c +++ b/src/interfaces/libpq/fe-connect.c @@ -6825,7 +6825,9 @@ end: /* Not at the end of the string yet? Fail. */ if (*q != '\0') { - libpq_append_error(errorMessage, "trailing data found: \"%s\"", str); + libpq_append_error(errorMessage, + "unexpected spaces found in \"%s\", use percent-encoded spaces (%%20) instead", + str); free(buf); return NULL; } -- cgit v1.2.3