From 6a93cb689a03aaaa04bbc446778de9029efad56d Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Mon, 15 Nov 2010 14:27:09 -0500 Subject: Fix aboriginal mistake in plpython's set-returning-function support. We must stay in the function's SPI context until done calling the iterator that returns the set result. Otherwise, any attempt to invoke SPI features in the python code called by the iterator will malfunction. Diagnosis and patch by Jan Urbanski, per bug report from Jean-Baptiste Quenot. Back-patch to 8.2; there was no support for SRFs in previous versions of plpython. --- src/pl/plpython/sql/plpython_function.sql | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/pl/plpython/sql/plpython_function.sql') diff --git a/src/pl/plpython/sql/plpython_function.sql b/src/pl/plpython/sql/plpython_function.sql index 224d5196a3c..133704dbbe7 100644 --- a/src/pl/plpython/sql/plpython_function.sql +++ b/src/pl/plpython/sql/plpython_function.sql @@ -444,6 +444,15 @@ class producer: return producer(count, content) $$ LANGUAGE plpythonu; +CREATE FUNCTION test_setof_spi_in_iterator() RETURNS SETOF text AS +$$ + for s in ('Hello', 'Brave', 'New', 'World'): + plpy.execute('select 1') + yield s + plpy.execute('select 2') +$$ +LANGUAGE plpythonu; + -- -- Test returning tuples -- cgit v1.2.3