From b0f069d931f0a3d4a39aeeb230baf2f2b18cb3c3 Mon Sep 17 00:00:00 2001 From: Tom Lane Date: Sat, 1 Jul 2017 14:25:09 -0400 Subject: Clean up misuse and nonuse of poll_query_until(). Several callers of PostgresNode::poll_query_until() neglected to check for failure; I do not think that's optional. Also, rewrite one place that had reinvented poll_query_until() for no very good reason. --- src/test/modules/commit_ts/t/003_standby_2.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/test/modules/commit_ts') diff --git a/src/test/modules/commit_ts/t/003_standby_2.pl b/src/test/modules/commit_ts/t/003_standby_2.pl index 2fd561115cb..eccaf07561e 100644 --- a/src/test/modules/commit_ts/t/003_standby_2.pl +++ b/src/test/modules/commit_ts/t/003_standby_2.pl @@ -55,7 +55,8 @@ $master->append_conf('postgresql.conf', 'track_commit_timestamp = off'); $master->restart; system_or_bail('pg_ctl', '-D', $standby->data_dir, 'promote'); -$standby->poll_query_until('postgres', "SELECT pg_is_in_recovery() <> true"); +$standby->poll_query_until('postgres', "SELECT NOT pg_is_in_recovery()") + or die "standby never exited recovery"; $standby->safe_psql('postgres', "create table t11()"); my $standby_ts = $standby->safe_psql('postgres', -- cgit v1.2.3