From cbe04e5d729f292bcf9b06f5d774884b4511b18a Mon Sep 17 00:00:00 2001 From: Heikki Linnakangas Date: Tue, 2 Dec 2025 21:11:15 +0200 Subject: Fix amcheck's handling of half-dead B-tree pages amcheck incorrectly reported the following error if there were any half-dead pages in the index: ERROR: mismatch between parent key and child high key in index "amchecktest_id_idx" It's expected that a half-dead page does not have a downlink in the parent level, so skip the test. Reported-by: Konstantin Knizhnik Reviewed-by: Peter Geoghegan Reviewed-by: Mihail Nikalayeu Discussion: https://www.postgresql.org/message-id/33e39552-6a2a-46f3-8b34-3f9f8004451f@garret.ru Backpatch-through: 14 --- .../modules/nbtree/expected/nbtree_half_dead_pages.out | 14 ++++++++++++++ src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql | 5 +++++ 2 files changed, 19 insertions(+) (limited to 'src') diff --git a/src/test/modules/nbtree/expected/nbtree_half_dead_pages.out b/src/test/modules/nbtree/expected/nbtree_half_dead_pages.out index 8fd472f8df2..e94f016696d 100644 --- a/src/test/modules/nbtree/expected/nbtree_half_dead_pages.out +++ b/src/test/modules/nbtree/expected/nbtree_half_dead_pages.out @@ -11,6 +11,7 @@ -- This uses injection points to interrupt some page deletions set client_min_messages TO 'warning'; create extension if not exists injection_points; +create extension if not exists amcheck; reset client_min_messages; -- Make all injection points local to this process, for concurrency. SELECT injection_points_set_local(); @@ -57,6 +58,13 @@ select * from nbtree_half_dead_pages where id > 99998 and id < 120002; 120001 (4 rows) +-- Also check the index with amcheck +select bt_index_parent_check('nbtree_half_dead_pages_id_idx'::regclass, true, true); + bt_index_parent_check +----------------------- + +(1 row) + -- Finish the deletion and re-check vacuum nbtree_half_dead_pages; NOTICE: notice triggered for injection point nbtree-finish-half-dead-page-vacuum @@ -69,3 +77,9 @@ select * from nbtree_half_dead_pages where id > 99998 and id < 120002; 120001 (4 rows) +select bt_index_parent_check('nbtree_half_dead_pages_id_idx'::regclass, true, true); + bt_index_parent_check +----------------------- + +(1 row) + diff --git a/src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql b/src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql index d4b9a3f824d..fd279b87e0e 100644 --- a/src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql +++ b/src/test/modules/nbtree/sql/nbtree_half_dead_pages.sql @@ -12,6 +12,7 @@ -- This uses injection points to interrupt some page deletions set client_min_messages TO 'warning'; create extension if not exists injection_points; +create extension if not exists amcheck; reset client_min_messages; -- Make all injection points local to this process, for concurrency. @@ -38,6 +39,10 @@ SELECT injection_points_detach('nbtree-leave-page-half-dead'); select * from nbtree_half_dead_pages where id > 99998 and id < 120002; +-- Also check the index with amcheck +select bt_index_parent_check('nbtree_half_dead_pages_id_idx'::regclass, true, true); + -- Finish the deletion and re-check vacuum nbtree_half_dead_pages; select * from nbtree_half_dead_pages where id > 99998 and id < 120002; +select bt_index_parent_check('nbtree_half_dead_pages_id_idx'::regclass, true, true); -- cgit v1.2.3