summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2025-08-21 13:46:56 -0700
committerJunio C Hamano <gitster@pobox.com>2025-08-21 13:46:57 -0700
commit1fe6955fd4e0de21a5581376589c8df56fae6adf (patch)
tree23a6df77791993ec24d8fda0aa7bf21ebd0f4d96
parentc44beea485f0f2feaf460e2ac87fdd5608d63cf0 (diff)
parent4d491ade8f6597904a7b79ff5d34f8524f915ac2 (diff)
Merge branch 'js/rebase-i-allow-drop-on-a-merge'
During interactive rebase, using 'drop' on a merge commit lead to an error, which was incorrect. * js/rebase-i-allow-drop-on-a-merge: rebase -i: permit 'drop' of a merge commit
-rw-r--r--sequencer.c1
-rwxr-xr-xt/t3404-rebase-interactive.sh1
2 files changed, 2 insertions, 0 deletions
diff --git a/sequencer.c b/sequencer.c
index aaf2e4df64..9ae40a91b2 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -2721,6 +2721,7 @@ static int check_merge_commit_insn(enum todo_command command)
return error(_("cannot squash merge commit into another commit"));
case TODO_MERGE:
+ case TODO_DROP:
return 0;
default:
diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh
index 6bac217ed3..34d6ad0770 100755
--- a/t/t3404-rebase-interactive.sh
+++ b/t/t3404-rebase-interactive.sh
@@ -2263,6 +2263,7 @@ test_expect_success 'non-merge commands reject merge commits' '
edit $oid
fixup $oid
squash $oid
+ drop $oid # acceptable, no advice
EOF
(
set_replace_editor todo &&