diff options
| author | Patrick Steinhardt <ps@pks.im> | 2024-09-30 11:14:01 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-09-30 11:23:07 -0700 |
| commit | 9d4855eef3644ac00d62e08d797ff7db554ca65d (patch) | |
| tree | 137bebed26b620aa0d80eb67b79ca47975fc9f4f | |
| parent | 7f97266ee15d2a30dbc12c9a7f282a9f94b32476 (diff) | |
midx-write: fix leaking buffer
The buffer used to compute the final MIDX name is never released. Plug
this memory leak.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | midx-write.c | 2 | ||||
| -rwxr-xr-x | t/t5334-incremental-multi-pack-index.sh | 2 |
2 files changed, 4 insertions, 0 deletions
diff --git a/midx-write.c b/midx-write.c index 1ef62c4f4b..625c7d3137 100644 --- a/midx-write.c +++ b/midx-write.c @@ -1445,6 +1445,8 @@ static int write_midx_internal(const char *object_dir, return -1; } + strbuf_release(&final_midx_name); + keep_hashes[ctx.num_multi_pack_indexes_before] = xstrdup(hash_to_hex(midx_hash)); diff --git a/t/t5334-incremental-multi-pack-index.sh b/t/t5334-incremental-multi-pack-index.sh index c3b08acc73..471994c4bc 100755 --- a/t/t5334-incremental-multi-pack-index.sh +++ b/t/t5334-incremental-multi-pack-index.sh @@ -1,6 +1,8 @@ #!/bin/sh test_description='incremental multi-pack-index' + +TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh . "$TEST_DIRECTORY"/lib-midx.sh |
