diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2022-11-28 15:18:55 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-12-02 16:38:12 +0900 |
commit | 243caa898284413c2e53388787c8c6b599b91fb4 (patch) | |
tree | 7362e754b0709aa7527d668c59673d4767bc1f6e /builtin/commit-graph.c | |
parent | e7e5c6f715b2de7bea0d39c7d2ba887335b40aa0 (diff) |
t5314: check exit code of "git"
Amend the test added in [1] to check the exit code of the "git"
invocations. An in-flight change[2] introduced a memory leak in these
invocations, which went undetected unless we were running under
"GIT_TEST_SANITIZE_LEAK_LOG=true".
Note that the in-flight change made 8 test files fail, but as far as I
can tell only this one would have had its exit code hidden unless
under "GIT_TEST_SANITIZE_LEAK_LOG=true". The rest would be caught
without it.
We could pick other variable names here than "ln%d", e.g. "commit",
"dummy_blob" and "file_blob", but having the "rev-parse" invocations
aligned makes the difference between them more readable, so let's pick
"ln%d".
1. 4cf2143e029 (pack-objects: break delta cycles before delta-search
phase, 2016-08-11)
2. https://lore.kernel.org/git/221128.868rjvmi3l.gmgdl@evledraar.gmail.com/
3. faececa53f9 (test-lib: have the "check" mode for SANITIZE=leak
consider leak logs, 2022-07-28)
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit-graph.c')
0 files changed, 0 insertions, 0 deletions