summaryrefslogtreecommitdiff
path: root/builtin/commit-graph.c
diff options
context:
space:
mode:
authorLidong Yan <502024330056@smail.nju.edu.cn>2025-06-04 03:11:15 +0000
committerJunio C Hamano <gitster@pobox.com>2025-06-04 08:55:30 -0700
commit7082da85cbd03404a21a3ba02158d7ab1989cfc2 (patch)
tree5819b7e23b19adad3fd5f855ef33d108ac1fce97 /builtin/commit-graph.c
parentd50a5e8939abfc07c2ff97ae72e9330939b36ee0 (diff)
commit-graph: fix start_delayed_progress() leak
In commit-graph.c:graph_write(), if read_one_commit() failed, progress allocated in start_delayed_progress() will leak. Add stop_progress() before goto cleanup. Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn> Acked-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit-graph.c')
-rw-r--r--builtin/commit-graph.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 8ca75262c5..bcd5ff6798 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -311,6 +311,7 @@ static int graph_write(int argc, const char **argv, const char *prefix,
while (strbuf_getline(&buf, stdin) != EOF) {
if (read_one_commit(&commits, progress, buf.buf)) {
result = 1;
+ stop_progress(&progress);
goto cleanup;
}
}