diff options
author | Jeff King <peff@peff.net> | 2025-01-07 02:18:24 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2025-01-07 08:31:45 -0800 |
commit | ddb5287894c491686e6dc1a82e1c3d0f34e56a7f (patch) | |
tree | d8b27e70d313b3c7d0266a7abeecbf8b58c5dfe9 /builtin/commit.c | |
parent | 4f71522dfb7fc53eff569023303980c66114b1bc (diff) |
t7407: use test_grep
There are a few grep calls here that can benefit from test_grep, which
produces more user-friendly output when it fails.
One of these calls also passes "-sq", which is curious. The "-q" option
suppresses the matched output. But test output is either already
redirected to /dev/null in non-verbose mode, and in verbose mode it's
better to see the output. The "-s" option suppresses errors opening
files, but we are just grepping in the "expected" file we just
generated, so it should not be needed. Neither of these was really
hurting anything, but they are not a style we'd like to see emulated. So
get rid of them.
(It is also curious to grep in the expected file in the first place, but
that is because we are auto-generating the expectation from a Git
command. So this is double-checking it did what we wanted).
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/commit.c')
0 files changed, 0 insertions, 0 deletions