summaryrefslogtreecommitdiff
path: root/git-gui/lib/commit.tcl
diff options
context:
space:
mode:
authorPratyush Yadav <me@yadavpratyush.com>2023-01-24 14:13:46 +0100
committerPratyush Yadav <me@yadavpratyush.com>2023-01-24 14:14:05 +0100
commit1e5a89c1b4da13b89b0b66ad59d098ced832c3f0 (patch)
tree228fd4a009b394c0c28a0320c79ba6965748dba9 /git-gui/lib/commit.tcl
parentfa28da02024ea4858c29b7caec30a18ee2d6f404 (diff)
parentaae9560a355d4ab91385e49eae62fade2ddd27ef (diff)
Merge branch 'js/windows-rce'
Fix a Remote Code Execution vulnerability on Windows. This is caused by the fact that Tcl on Windows always includes the current directory when looking for an executable. Therefore malicious repositories can ship with an aspell.exe in their top-level directory which is executed by Git GUI without giving the user a chance to inspect it first, i.e. running untrusted code. This merge fixes CVE-2022-41953. * js/windows-rce: Work around Tcl's default `PATH` lookup Move the `_which` function (almost) to the top Move is_<platform> functions to the beginning is_Cygwin: avoid `exec`ing anything windows: ignore empty `PATH` elements
Diffstat (limited to 'git-gui/lib/commit.tcl')
0 files changed, 0 insertions, 0 deletions