summaryrefslogtreecommitdiff
path: root/git-svn.perl
diff options
context:
space:
mode:
authorPatrick Steinhardt <ps@pks.im>2023-11-10 11:01:15 +0100
committerJunio C Hamano <gitster@pobox.com>2023-11-11 09:21:00 +0900
commit13420028e5b119d27277d521f4d267212c5ca21c (patch)
tree4d5279a48a367ea27df13cbeb8e9ba1b1dae3808 /git-svn.perl
parentdadef801b365989099a9929e995589e455c51fed (diff)
global: convert trivial usages of `test <expr> -a/-o <expr>`
Our coding guidelines say to not use `test` with `-a` and `-o` because it can easily lead to bugs. Convert trivial cases where we still use these to instead instead concatenate multiple invocations of `test` via `&&` and `||`, respectively. While not all of the converted instances can cause ambiguity, it is worth getting rid of all of them regardless: - It becomes easier to reason about the code as we do not have to argue why one use of `-a`/`-o` is okay while another one isn't. - We don't encourage people to use these expressions. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-svn.perl')
0 files changed, 0 insertions, 0 deletions