diff options
author | Patrick Steinhardt <ps@pks.im> | 2024-11-20 14:39:37 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2024-11-21 08:23:42 +0900 |
commit | 141766d1bb801ae2a9c7358920ce8dc9697f53c4 (patch) | |
tree | 0d8c3bfc70bebdf1cfcd5ff7a2483702c4f8174b /gitweb/static/js/javascript-detection.js | |
parent | c1e98f90103e8d98ef441ce8f609cf3bc8fa538b (diff) |
line-log: fix leak when rewriting commit parents
In `process_ranges_merge_commit()` we try to figure out which of the
parents can be blamed for the given line changes. When we figure out
that none of the files in the line-log have changed we assign the
complete blame to that commit and rewrite the parents of the current
commit to only use that single parent.
This is done via `commit_list_append()`, which is misleadingly _not_
appending to the list of parents. Instead, we overwrite the parents with
the blamed parent. This makes us lose track of the old pointers,
creating a memory leak.
Fix this issue by freeing the parents before we overwrite them.
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gitweb/static/js/javascript-detection.js')
0 files changed, 0 insertions, 0 deletions