summaryrefslogtreecommitdiff
path: root/help.c
diff options
context:
space:
mode:
authorDavid Aguilar <davvid@gmail.com>2025-02-01 13:33:18 -0800
committerJunio C Hamano <gitster@pobox.com>2025-02-03 15:22:03 -0800
commite21bf2c4314840dba4f45c6e7bbc96a6fc0a8f61 (patch)
tree9aacc42855bb7000f1d7413b1c1fc81c9f1e0e6a /help.c
parenta0fc18f0427fa9e4bd04cae60bee346b6ae78663 (diff)
help: show the suggested command when help.autocorrect is false
Make the handling of false boolean values for help.autocorrect consistent with the handling of value 0 by showing the suggested commands but not running them. Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: David Aguilar <davvid@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'help.c')
-rw-r--r--help.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/help.c b/help.c
index 7148963e46..55425c0d97 100644
--- a/help.c
+++ b/help.c
@@ -552,6 +552,7 @@ struct help_unknown_cmd_config {
struct cmdnames aliases;
};
+#define AUTOCORRECT_SHOW (-4)
#define AUTOCORRECT_PROMPT (-3)
#define AUTOCORRECT_NEVER (-2)
#define AUTOCORRECT_IMMEDIATELY (-1)
@@ -562,7 +563,7 @@ static int parse_autocorrect(const char *value)
case 1:
return AUTOCORRECT_IMMEDIATELY;
case 0:
- return AUTOCORRECT_NEVER;
+ return AUTOCORRECT_SHOW;
default: /* other random text */
break;
}
@@ -713,7 +714,8 @@ char *help_unknown_cmd(const char *cmd)
n++)
; /* still counting */
}
- if (cfg.autocorrect && n == 1 && SIMILAR_ENOUGH(best_similarity)) {
+ if (cfg.autocorrect && cfg.autocorrect != AUTOCORRECT_SHOW && n == 1 &&
+ SIMILAR_ENOUGH(best_similarity)) {
char *assumed = xstrdup(main_cmds.names[0]->name);
fprintf_ln(stderr,