diff options
| author | Karthik Nayak <karthik.188@gmail.com> | 2024-06-07 15:32:58 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-06-07 10:25:44 -0700 |
| commit | aba381c09034c2c31f3476e8cc9a46ea6889f1d5 (patch) | |
| tree | e4b1cf90e57660ce1971524576f435c68a0bc8fa /refs/reftable-backend.c | |
| parent | 939d49e9bdd03ec9e0d86fe8bc4de4540df035db (diff) | |
refs: create and use `ref_update_expects_existing_old_ref()`
The files and reftable backend, need to check if a ref must exist, so
that the required validation can be done. A ref must exist only when the
`old_oid` value of the update has been explicitly set and it is not the
`null_oid` value.
Since we also support symrefs now, we need to ensure that even when
`old_target` is set a ref must exist. While this was missed when we
added symref support in transactions, there are no active users of this
path. As we introduce the 'symref-verify' command in the upcoming
commits, it is important to fix this.
So let's export this to a function called
`ref_update_expects_existing_old_ref()` and expose it internally via
'refs-internal.h'.
Helped-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'refs/reftable-backend.c')
| -rw-r--r-- | refs/reftable-backend.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/refs/reftable-backend.c b/refs/reftable-backend.c index 1b92c396b6..019b99181d 100644 --- a/refs/reftable-backend.c +++ b/refs/reftable-backend.c @@ -827,7 +827,7 @@ static int reftable_be_transaction_prepare(struct ref_store *ref_store, ¤t_oid, &referent, &u->type); if (ret < 0) goto done; - if (ret > 0 && (!(u->flags & REF_HAVE_OLD) || is_null_oid(&u->old_oid))) { + if (ret > 0 && !ref_update_expects_existing_old_ref(u)) { /* * The reference does not exist, and we either have no * old object ID or expect the reference to not exist. |