summaryrefslogtreecommitdiff
path: root/replace-object.c
diff options
context:
space:
mode:
authorEric Sunshine <sunshine@sunshineco.com>2023-06-29 14:13:33 -0400
committerJunio C Hamano <gitster@pobox.com>2023-06-29 13:58:57 -0700
commit6e6a529b573398f0a8828551cf04dafb4f084c9a (patch)
treee637673d12cf8b944bbd29ec212d5931cffb092a /replace-object.c
parent8d3e7eac529b42319622692028b45670bdff8835 (diff)
fsck: avoid misleading variable name
When reporting a problem, `git fsck` emits a message such as: missing blob 1234abcd (:file) However, this can be ambiguous when the problem is detected in the index of a worktree other than the one in which `git fsck` was invoked. To address this shortcoming, 592ec63b38 (fsck: mention file path for index errors, 2023-02-24) enhanced the output to mention the path of the index when the problem is detected in some other worktree: missing blob 1234abcd (.git/worktrees/wt/index:file) Unfortunately, the variable in fsck_index() which controls whether the index path should be shown is misleadingly named "is_main_index" which can be misunderstood as referring to the main worktree (i.e. the one housing the .git/ repository) rather than to the current worktree (i.e. the one in which `git fsck` was invoked). Avoid such potential confusion by choosing a name more reflective of its actual purpose. Signed-off-by: Eric Sunshine <sunshine@sunshineco.com> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'replace-object.c')
0 files changed, 0 insertions, 0 deletions