diff options
| author | Johannes Schindelin <johannes.schindelin@gmx.de> | 2024-09-04 16:16:59 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2024-09-04 08:41:37 -0700 |
| commit | fe7066a9d97bb2546a717911bbda6c43bf02087a (patch) | |
| tree | bd0734ead3503cd80f49d09e3400e33662e64d16 /t/unit-tests/clar/clar.c | |
| parent | 7d835637136a0958e7515c760201613305f0a1c2 (diff) | |
clar: stop including `shellapi.h` unnecessarily
The `shellapi.h` header was included as of
https://github.com/clar-test/clar/commit/136e763211aa, to have
`SHFileOperation()` declared so that it could be called.
However, https://github.com/clar-test/clar/commit/5ce31b69b525 removed
that call, and therefore that `#include <shellapi.h>` is unnecessary.
It is also unwanted in Git because this project uses a subset of Git for
Windows' SDK in its CI builds that (for bandwidth reasons) excludes tons
of header files, including `shellapi.h`.
So let's remove it.
Note: Since the `windows.h` header would include `shellapi.h` anyway, we
also define `WIN32_LEAN_AND_MEAN` to avoid this and similar other
unnecessary includes before including `windows.h`.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/unit-tests/clar/clar.c')
| -rw-r--r-- | t/unit-tests/clar/clar.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/unit-tests/clar/clar.c b/t/unit-tests/clar/clar.c index e2ebe551d3..cef0f023c2 100644 --- a/t/unit-tests/clar/clar.c +++ b/t/unit-tests/clar/clar.c @@ -19,9 +19,9 @@ #include <sys/stat.h> #ifdef _WIN32 +# define WIN32_LEAN_AND_MEAN # include <windows.h> # include <io.h> -# include <shellapi.h> # include <direct.h> # define _MAIN_CC __cdecl |