diff options
author | Junio C Hamano <gitster@pobox.com> | 2024-02-07 10:46:54 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2024-02-07 10:47:25 -0800 |
commit | abfbff61efc4d91dc964eb2360760fa640ad0f0f (patch) | |
tree | fa525820b422eb6e524c7f554a6e82aeee80655f /t/unit-tests/t-basic.c | |
parent | 564d0252ca632e0264ed670534a51d18a689ef5d (diff) |
tag: fix sign_buffer() call to create a signed tag
The command "git tag -s" internally calls sign_buffer() to make a
cryptographic signature using the chosen backend like GPG and SSH.
The internal helper functions used by "git tag" implementation seem
to use a "negative return values are errors, zero or positive return
values are not" convention, and there are places (e.g., verify_tag()
that calls gpg_verify_tag()) that these internal helper functions
translate return values that signal errors to conform to this
convention, but do_sign() that calls sign_buffer() forgets to do so.
Fix it, so that a failed call to sign_buffer() that can return the
exit status from pipe_command() will not be overlooked.
Reported-by: Sergey Kosukhin <skosukhin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/unit-tests/t-basic.c')
0 files changed, 0 insertions, 0 deletions