diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2011-11-06 13:06:22 +0100 | 
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-11-06 10:36:59 -0800 | 
| commit | 473f4c96e315478185c4a07d6e7fb65801ee40b9 (patch) | |
| tree | a90fbf2dcb7f717d3ee324bf94f30d7e7803b8cc /vcs-svn/obj_pool.h | |
| parent | 703f05ad5835cff92b12c29aecf8d724c8c847e2 (diff) | |
apply: get rid of useless x < 0 comparison on a size_t type
According to the C standard size_t is always unsigned, therefore the
comparison "n1 < 0 || n2 < 0" when n1 and n2 are size_t will always be
false.
This was raised by clang 2.9 which throws this warning when compiling
apply.c:
    builtin/apply.c:253:9: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
            if (n1 < 0 || n2 < 0)
                ~~ ^ ~
    builtin/apply.c:253:19: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare]
            if (n1 < 0 || n2 < 0)
                          ~~ ^ ~
This check was originally added in v1.6.5-rc0~53^2 by Giuseppe Bilotta
while adding an option to git-apply to ignore whitespace differences.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'vcs-svn/obj_pool.h')
0 files changed, 0 insertions, 0 deletions
