diff options
Diffstat (limited to 'run-command.c')
| -rw-r--r-- | run-command.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/run-command.c b/run-command.c index 402138b8b5..d527c46175 100644 --- a/run-command.c +++ b/run-command.c @@ -515,7 +515,15 @@ static void atfork_prepare(struct atfork_state *as) { sigset_t all; - if (sigfillset(&all)) + /* + * Do not use the return value of sigfillset(). It is transparently 0 + * on some platforms, meaning a clever compiler may complain that + * the conditional body is dead code. Instead, check for error via + * errno, which outsmarts the compiler. + */ + errno = 0; + sigfillset(&all); + if (errno) die_errno("sigfillset"); #ifdef NO_PTHREADS if (sigprocmask(SIG_SETMASK, &all, &as->old)) |