diff options
| author | Tony Luck <tony.luck@intel.com> | 2004-10-20 06:37:21 +0000 |
|---|---|---|
| committer | Tony Luck <aegl@agluck-lia64.sc.intel.com> | 2004-10-20 06:37:21 +0000 |
| commit | 12ac2444cc34dbdeac9031dff09bebf6cf8428a4 (patch) | |
| tree | ada96f7f0fba6bd5e2ba1433bd28a2e2e245ebd4 | |
| parent | f22e2f3883fccb3294cea598d5b2152e3091b044 (diff) | |
[IA64] uninitialised flags element could cause crashes
window is not zeroed, so the flags should be assigned, not modified.
This can lead to crashes at boot if the IO and Memory resources overlap.
Patch supplied by Matthew Wilcox
Signed-off-by: Tony Luck <tony.luck@intel.com>
| -rw-r--r-- | arch/ia64/pci/pci.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index 9a5f1baf4745..36d81e82d088 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c @@ -275,7 +275,7 @@ add_window (struct acpi_resource *res, void *data) return AE_OK; window = &info->controller->window[info->controller->windows++]; - window->resource.flags |= flags; + window->resource.flags = flags; window->resource.start = addr.min_address_range; window->resource.end = addr.max_address_range; window->offset = offset; |