diff options
| author | Riana Tauro <riana.tauro@intel.com> | 2025-12-19 16:22:27 +0530 |
|---|---|---|
| committer | Rodrigo Vivi <rodrigo.vivi@intel.com> | 2025-12-19 11:01:57 -0500 |
| commit | 13fe9fa7f41a2f3a0ce25d27297a379560e45b2d (patch) | |
| tree | e890892e0f7ac2a3c2bbbac4b8aa825e683e7187 | |
| parent | 3d50c69c5819b20149946fda084bb3d6bfda2c44 (diff) | |
drm/xe/xe_survivability: Add index bound check
Fix static analysis tool reported issue. Add index bound check before
accessing info array to prevent out of bound.
Fixes: f4e9fc967afd ("drm/xe/xe_survivability: Redesign survivability mode")
Signed-off-by: Riana Tauro <riana.tauro@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patch.msgid.link/20251219105224.871930-6-riana.tauro@intel.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
| -rw-r--r-- | drivers/gpu/drm/xe/xe_survivability_mode.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/gpu/drm/xe/xe_survivability_mode.c b/drivers/gpu/drm/xe/xe_survivability_mode.c index 162b57a9ab94..4c716182ad3b 100644 --- a/drivers/gpu/drm/xe/xe_survivability_mode.c +++ b/drivers/gpu/drm/xe/xe_survivability_mode.c @@ -251,10 +251,14 @@ static umode_t survivability_info_attrs_visible(struct kobject *kobj, struct att struct xe_survivability *survivability = &xe->survivability; u32 *info = survivability->info; - /* FDO mode is visible only when supported */ - if (idx >= MAX_SCRATCH_REG && survivability->version >= 2) + /* + * Last index in survivability_info_attrs is fdo mode and is applicable only in + * version 2 of survivability mode + */ + if (idx == MAX_SCRATCH_REG && survivability->version >= 2) return 0400; - else if (info[idx]) + + if (idx < MAX_SCRATCH_REG && info[idx]) return 0400; return 0; |