summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2025-07-18 16:23:05 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2025-10-23 16:24:41 +0200
commit29319ff77559a1f0f9cfb176e7ac4d9a2897f61e (patch)
tree8af9018888114b6c48d7255e5515ab3719274bcf
parentb5b378d254e270bafb4bad98f69a2228c1441242 (diff)
drm/xe: Fix an IS_ERR() vs NULL bug in xe_tile_alloc_vram()
commit 6c9e64e83b22405622d1f47417cdb0d20d49ca35 upstream. The xe_vram_region_alloc() function returns NULL on error. It never returns error pointers. Update the error checking to match. Fixes: 4b0a5f5ce784 ("drm/xe: Unify the initialization of VRAM regions") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/5449065e-9758-4711-b706-78771c0753c4@sabinyo.mountain Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/gpu/drm/xe/xe_tile.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/xe/xe_tile.c b/drivers/gpu/drm/xe/xe_tile.c
index 68b84111f26b..e34edff0eaa1 100644
--- a/drivers/gpu/drm/xe/xe_tile.c
+++ b/drivers/gpu/drm/xe/xe_tile.c
@@ -116,8 +116,8 @@ int xe_tile_alloc_vram(struct xe_tile *tile)
return 0;
vram = xe_vram_region_alloc(xe, tile->id, XE_PL_VRAM0 + tile->id);
- if (IS_ERR(vram))
- return PTR_ERR(vram);
+ if (!vram)
+ return -ENOMEM;
tile->mem.vram = vram;
return 0;