diff options
| author | Patrick Mochel <mochel@osdl.org> | 2003-01-12 23:38:44 -0600 |
|---|---|---|
| committer | Patrick Mochel <mochel@osdl.org> | 2003-01-12 23:38:44 -0600 |
| commit | 3f47b64a6a543558d27729d040e302e5bcffdfde (patch) | |
| tree | 34923f9f3d33674cbea6974125a0d083d9933b0c | |
| parent | 4b8d028a2fba82b354a33dd5322f28a0b2270e41 (diff) | |
sysfs: fixup SCSI sysfs files
- Reinstate count parameter for store() methods.
- Remove off parameter from st.c and osst.c sysfs methods.
- Remove count parameter from st.c and osst.c show() methods.
| -rw-r--r-- | drivers/scsi/osst.c | 8 | ||||
| -rw-r--r-- | drivers/scsi/scsi_sysfs.c | 8 | ||||
| -rw-r--r-- | drivers/scsi/st.c | 12 |
3 files changed, 13 insertions, 15 deletions
diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index f7c3379dafe3..1c2a41c621aa 100644 --- a/drivers/scsi/osst.c +++ b/drivers/scsi/osst.c @@ -5325,17 +5325,17 @@ __setup("osst=", osst_setup); #endif /* Driverfs file support */ -static ssize_t osst_device_kdev_read(struct device *driverfs_dev, char *page, size_t count, loff_t off) +static ssize_t osst_device_kdev_read(struct device *driverfs_dev, char *page) { kdev_t kdev; kdev.value=(int)(long)driverfs_dev->driver_data; - return off ? 0 : sprintf(page, "%x\n",kdev.value); + return sprintf(page, "%x\n",kdev.value); } static DEVICE_ATTR(kdev,S_IRUGO,osst_device_kdev_read,NULL); -static ssize_t osst_device_type_read(struct device *driverfs_dev, char *page, size_t count, loff_t off) +static ssize_t osst_device_type_read(struct device *driverfs_dev, char *page) { - return off ? 0 : sprintf (page, "CHR\n"); + return sprintf (page, "CHR\n"); } static DEVICE_ATTR(type,S_IRUGO,osst_device_type_read,NULL); diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index e18776421397..9a7b256add6a 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -158,12 +158,12 @@ static DEVICE_ATTR(field, S_IRUGO, show_##field, NULL) show_function(field, format_string) \ \ static ssize_t \ -store_##field (struct device *dev, const char *buf) \ +store_##field (struct device *dev, const char *buf, size_t count) \ { \ struct scsi_device *sdev; \ sdev = to_scsi_device(dev); \ snscanf (buf, 20, format_string, &sdev->field); \ - return strlen(buf); \ + return count; \ } \ static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, show_##field, store_##field) @@ -175,7 +175,7 @@ static DEVICE_ATTR(field, S_IRUGO | S_IWUSR, show_##field, store_##field) show_function(field, "%d\n") \ \ static ssize_t \ -store_##field (struct device *dev, const char *buf) \ +store_##field (struct device *dev, const char *buf, size_t count) \ { \ int ret; \ struct scsi_device *sdev; \ @@ -183,7 +183,7 @@ store_##field (struct device *dev, const char *buf) \ if (ret >= 0) { \ sdev = to_scsi_device(dev); \ sdev->field = ret; \ - ret = strlen(buf); \ + ret = count; \ } \ return ret; \ } \ diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c index b463de9d1367..7f38fe7f0b3e 100644 --- a/drivers/scsi/st.c +++ b/drivers/scsi/st.c @@ -3615,19 +3615,17 @@ __setup("st=", st_setup); #endif /* Driverfs file support */ -static ssize_t st_device_kdev_read(struct device *driverfs_dev, - char *page, size_t count, loff_t off) +static ssize_t st_device_kdev_read(struct device *dev, char *page) { kdev_t kdev; - kdev.value=(int)(long)driverfs_dev->driver_data; - return off ? 0 : sprintf(page, "%x\n",kdev.value); + kdev.value=(int)dev->driver_data; + return sprintf(page, "%x\n",kdev.value); } static DEVICE_ATTR(kdev,S_IRUGO,st_device_kdev_read,NULL); -static ssize_t st_device_type_read(struct device *driverfs_dev, - char *page, size_t count, loff_t off) +static ssize_t st_device_type_read(struct device *ev, char * page) { - return off ? 0 : sprintf (page, "CHR\n"); + return sprintf (page, "CHR\n"); } static DEVICE_ATTR(type,S_IRUGO,st_device_type_read,NULL); |
