diff options
| author | Antheas Kapenekakis <lkml@antheas.dev> | 2026-01-22 08:50:39 +0100 |
|---|---|---|
| committer | Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> | 2026-01-28 14:02:28 +0200 |
| commit | 4ac74ea68f6429512faf06a3365a2ba6b96d48d6 (patch) | |
| tree | fc38f4097ce85701f5dac0b4bd1e5742f81a3d1e | |
| parent | 2b92b797a153258c9f17786c2ab28b568f5aadf3 (diff) | |
HID: asus: early return for ROG devices
Some ROG devices have a new dynamic backlight interface for control by
Windows. This interface does not create an ->input device, causing the
kernel to print an error message and to eject it. In addition, ROG
devices have proper HID names in their descriptors so renaming them is
not necessary.
Therefore, if a device is identified as ROG, early return from probe to
skip renaming and ->input checks.
Acked-by: Benjamin Tissoires <bentiss@kernel.org>
Reviewed-by: Denis Benato <benato.denis96@gmail.com>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
Link: https://patch.msgid.link/20260122075044.5070-7-lkml@antheas.dev
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
| -rw-r--r-- | drivers/hid/hid-asus.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index dc8795b59cc2..6084ec66a134 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -1233,6 +1233,13 @@ static int asus_probe(struct hid_device *hdev, const struct hid_device_id *id) hid_warn(hdev, "Failed to initialize backlight.\n"); /* + * For ROG keyboards, skip rename for consistency and ->input check as + * some devices do not have inputs. + */ + if (drvdata->quirks & QUIRK_ROG_NKEY_KEYBOARD) + return 0; + + /* * Check that input registration succeeded. Checking that * HID_CLAIMED_INPUT is set prevents a UAF when all input devices * were freed during registration due to no usages being mapped, |