diff options
| author | Anton Altaparmakov <aia21@cam.ac.uk> | 2004-06-28 19:36:39 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2004-06-28 19:36:39 -0700 |
| commit | 4d1ae8c58dd8a8505a7684fa393c95da04082ef7 (patch) | |
| tree | 4835d90e509410765050a4c587377cc5e72d5a7f | |
| parent | 0816a653a7ebdb43233b5a07042aecdb1f70e633 (diff) | |
[PATCH] Remove NOOP code from fs/buffer.c::drop_buffers()
I noticed that fs/buffer.c::drop_buffers() contains some code that
AFAICS doesn't actually do anything other than waste cpu cycles so here
is patch to remove it... The local variable was_uptodate is being
messed with but it is not being read anywhere so it seems entirely
pointless.
I assume this must be a remainder from old code which mucked around with
the page uptodateness but which has since been (re-)moved.
Signed-off-by: Anton Altaparmakov <aia21@cantab.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | fs/buffer.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/fs/buffer.c b/fs/buffer.c index 0b84c0f8470b..c877d7909571 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2895,7 +2895,6 @@ drop_buffers(struct page *page, struct buffer_head **buffers_to_free) { struct buffer_head *head = page_buffers(page); struct buffer_head *bh; - int was_uptodate = 1; bh = head; do { @@ -2903,8 +2902,6 @@ drop_buffers(struct page *page, struct buffer_head **buffers_to_free) set_bit(AS_EIO, &page->mapping->flags); if (buffer_busy(bh)) goto failed; - if (!buffer_uptodate(bh) && !buffer_req(bh)) - was_uptodate = 0; bh = bh->b_this_page; } while (bh != head); |