diff options
| author | Prasanna Meda <pmeda@akamai.com> | 2004-11-21 16:43:25 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2004-11-21 16:43:25 -0800 |
| commit | 4e7ef413ce126ec63ba30e802f175ffd941cc391 (patch) | |
| tree | 756ec86b12dff33c60897abb1222955140a3e706 | |
| parent | be3e0da98d860f6d2d04ec35c8495aaa3b077782 (diff) | |
[PATCH] /proc/cmdline missing mmput
Fix the mmput bug introduced while fixing cmdline race.
Signed-off-by: Prasanna Meda <pmeda@akamai.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | fs/proc/base.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/proc/base.c b/fs/proc/base.c index 91060b9921cc..7acfee6ece8d 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -343,7 +343,7 @@ static int proc_pid_cmdline(struct task_struct *task, char * buffer) if (!mm) goto out; if (!mm->arg_end) - goto out; /* Shh! No looking before we're done */ + goto out_mm; /* Shh! No looking before we're done */ len = mm->arg_end - mm->arg_start; @@ -366,8 +366,8 @@ static int proc_pid_cmdline(struct task_struct *task, char * buffer) res = strnlen(buffer, res); } } +out_mm: mmput(mm); - out: return res; } |