diff options
| author | Alexander Nyberg <alexn@dsv.su.se> | 2005-02-28 19:47:30 -0800 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-02-28 19:47:30 -0800 |
| commit | 678eef087f9a939085addfbeea887df1758a1f1d (patch) | |
| tree | c9e76da634dce92af715d4b3769812f7acd0afba | |
| parent | 7e629b50c50df16369bf229157af40236032def3 (diff) | |
[PATCH] SELinux: Leak in error path
There's a leak here in the first error path.
Found by the Coverity tool.
Signed-off-by: Alexander Nyberg <alexn@dsv.su.se>
Acked-by: James Morris <jmorris@redhat.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
| -rw-r--r-- | security/selinux/ss/conditional.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/security/selinux/ss/conditional.c b/security/selinux/ss/conditional.c index 90f5fbd5fad5..372e6a729b61 100644 --- a/security/selinux/ss/conditional.c +++ b/security/selinux/ss/conditional.c @@ -401,8 +401,10 @@ static int cond_read_node(struct policydb *p, struct cond_node *node, void *fp) expr->expr_type = le32_to_cpu(buf[0]); expr->bool = le32_to_cpu(buf[1]); - if (!expr_isvalid(p, expr)) + if (!expr_isvalid(p, expr)) { + kfree(expr); goto err; + } if (i == 0) { node->expr = expr; |