diff options
| author | Peter Rosin <peda@axentia.se> | 2016-09-14 15:24:12 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2016-11-20 01:17:34 +0000 |
| commit | 77d74c0a67c73002b379d14969a7cd6ebc2c61ff (patch) | |
| tree | 496235f15b33a282dcb02edd8661d8c296d5095a | |
| parent | 90e5f82c4e3c9c757790b80d4bc23aef5b428c44 (diff) | |
i2c: mux: pca954x: retry updating the mux selection on failure
commit 463e8f845cbf1c01e4cc8aeef1703212991d8e1e upstream.
The cached value of the last selected channel prevents retries on the
next call, even on failure to update the selected channel. Fix that.
Signed-off-by: Peter Rosin <peda@axentia.se>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
| -rw-r--r-- | drivers/i2c/muxes/i2c-mux-pca954x.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c index 9bd4212782ab..f1b945509477 100644 --- a/drivers/i2c/muxes/i2c-mux-pca954x.c +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c @@ -161,7 +161,7 @@ static int pca954x_select_chan(struct i2c_adapter *adap, /* Only select the channel if its different from the last channel */ if (data->last_chan != regval) { ret = pca954x_reg_write(adap, client, regval); - data->last_chan = regval; + data->last_chan = ret ? 0 : regval; } return ret; |