diff options
| author | Daniel Stone <daniels@collabora.com> | 2025-12-15 15:09:17 +0100 |
|---|---|---|
| committer | Heiko Stuebner <heiko@sntech.de> | 2026-01-08 20:00:34 +0100 |
| commit | 78de5d28d7207f816565fa43ec44e6735c319ddf (patch) | |
| tree | 6528341a7e9892c933c1826ac5b44b5b0ed67da3 | |
| parent | f1eac46fe5f7d4569681a648440d0f416a50c476 (diff) | |
drm/rockchip: vop2: Switch impossible format conditional to WARN_ON
We should never be able to create a framebuffer with an unsupported
format, so throw a warning if this ever happens.
Signed-off-by: Daniel Stone <daniels@collabora.com>
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patch.msgid.link/20251215-vop2-atomic-fixups-v5-1-83463c075a8d@collabora.com
| -rw-r--r-- | drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c index 498df0ce4680..20b49209ddcd 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -1030,7 +1030,8 @@ static int vop2_plane_atomic_check(struct drm_plane *plane, return 0; format = vop2_convert_format(fb->format->format); - if (format < 0) + /* We shouldn't be able to create a fb for an unsupported format */ + if (WARN_ON(format < 0)) return format; /* Co-ordinates have now been clipped */ |