diff options
| author | Navid Emamdoost <navid.emamdoost@gmail.com> | 2019-09-20 17:57:59 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-08-05 10:05:59 +0200 |
| commit | 7deb2dcb8963812742ed08420cfa4e23bbeda074 (patch) | |
| tree | f52bd28785c2c7d98e19d15bc78d071494186e35 | |
| parent | e15f8a9b0046418295d09db24c1ec306c80d013b (diff) | |
tracing: Have error path in predicate_parse() free its allocated memory
[ Upstream commit 96c5c6e6a5b6db592acae039fed54b5c8844cd35 ]
In predicate_parse, there is an error path that is not going to
out_free instead it returns directly which leads to a memory leak.
Link: http://lkml.kernel.org/r/20190920225800.3870-1-navid.emamdoost@gmail.com
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | kernel/trace/trace_events_filter.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c index b949c3917c67..9be3d1d1fcb4 100644 --- a/kernel/trace/trace_events_filter.c +++ b/kernel/trace/trace_events_filter.c @@ -451,8 +451,10 @@ predicate_parse(const char *str, int nr_parens, int nr_preds, switch (*next) { case '(': /* #2 */ - if (top - op_stack > nr_parens) - return ERR_PTR(-EINVAL); + if (top - op_stack > nr_parens) { + ret = -EINVAL; + goto out_free; + } *(++top) = invert; continue; case '!': /* #3 */ |