summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2025-11-01 00:48:31 -0400
committerAl Viro <viro@zeniv.linux.org.uk>2026-01-13 15:16:44 -0500
commit85a4fe3c99a78999e5ce41d51292a1b665f314be (patch)
tree3e30bcc5e50fc8c8c148faf817194190261f44c7
parentc3fa2b7cf5dda5a73480361303441db4ba7f0e6a (diff)
user_statfs(): import pathname only once
Convert the user_path_at() call inside a retry loop into getname_flags() + filename_lookup() + putname() and leave only filename_lookup() inside the loop. In this case we never pass LOOKUP_EMPTY, so getname_flags() is equivalent to plain getname(). The things could be further simplified by use of cleanup.h stuff, but let's not clutter the patch with that. Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--fs/statfs.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/fs/statfs.c b/fs/statfs.c
index a45ac85e6048..a5671bf6c7f0 100644
--- a/fs/statfs.c
+++ b/fs/statfs.c
@@ -99,8 +99,9 @@ int user_statfs(const char __user *pathname, struct kstatfs *st)
struct path path;
int error;
unsigned int lookup_flags = LOOKUP_FOLLOW|LOOKUP_AUTOMOUNT;
+ struct filename *name = getname(pathname);
retry:
- error = user_path_at(AT_FDCWD, pathname, lookup_flags, &path);
+ error = filename_lookup(AT_FDCWD, name, lookup_flags, &path, NULL);
if (!error) {
error = vfs_statfs(&path, st);
path_put(&path);
@@ -109,6 +110,7 @@ retry:
goto retry;
}
}
+ putname(name);
return error;
}