summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJens Axboe <axboe@suse.de>2002-09-29 22:33:22 -0700
committerLinus Torvalds <torvalds@penguin.transmeta.com>2002-09-29 22:33:22 -0700
commit88a745f564b92ea5d1baa669c265066636ac6c44 (patch)
treee797b934c9c6c3a7e09d94ff93f9615fab9962ff
parent9170c9efce0b728383126e8c508cd1474a9c73b0 (diff)
[PATCH] request_irq() use GFP_ATOMIC
The might_sleep() thing caught ide, which calls request_irq() with a lock held. It can be argued that this is a bad thing, however I think it can also validly be argued that requesting an irq should not be a blocking operation. This might even remove some driver bugs where usage count is not incremented during init... It can also be argued, that the very first irq requests cannot be blocking for io anyways, for good reason :-)
-rw-r--r--arch/i386/kernel/irq.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/i386/kernel/irq.c b/arch/i386/kernel/irq.c
index c0745578d0e7..e58629ba806a 100644
--- a/arch/i386/kernel/irq.c
+++ b/arch/i386/kernel/irq.c
@@ -455,7 +455,7 @@ int request_irq(unsigned int irq,
return -EINVAL;
action = (struct irqaction *)
- kmalloc(sizeof(struct irqaction), GFP_KERNEL);
+ kmalloc(sizeof(struct irqaction), GFP_ATOMIC);
if (!action)
return -ENOMEM;