summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlan Stern <stern@rowland.harvard.edu>2004-03-09 21:44:37 -0800
committerGreg Kroah-Hartman <greg@kroah.com>2004-03-09 21:44:37 -0800
commit8dbe0a71d2fef1253bfcd1c9273abafbebc724f2 (patch)
tree0193e0f3cdd764fcf5c3e989cac293128f5da606
parentbcffdf5cb05fd57b433c2d8c33b471cd3acc02f2 (diff)
[PATCH] USB: Altsetting/interface update for USB image drivers
This patch contains minute updates for the hpusbscsi, mdc800, and microtek drivers. Only two things are worth noting. In the mdc800 driver I removed some unnecessary calls to usb_driver_claim_interface(), usb_driver_release_interface(), and usb_set_interface(). Likewise, in the microtek driver I removed an unnecessary call to usb_set_interface().
-rw-r--r--drivers/usb/image/hpusbscsi.c2
-rw-r--r--drivers/usb/image/mdc800.c11
-rw-r--r--drivers/usb/image/microtek.c21
3 files changed, 5 insertions, 29 deletions
diff --git a/drivers/usb/image/hpusbscsi.c b/drivers/usb/image/hpusbscsi.c
index bc323a4c74bf..bd69f10c63f3 100644
--- a/drivers/usb/image/hpusbscsi.c
+++ b/drivers/usb/image/hpusbscsi.c
@@ -42,7 +42,7 @@ hpusbscsi_usb_probe(struct usb_interface *intf,
const struct usb_device_id *id)
{
struct usb_device *dev = interface_to_usbdev(intf);
- struct usb_host_interface *altsetting = intf->altsetting;
+ struct usb_host_interface *altsetting = intf->cur_altsetting;
struct hpusbscsi *new;
int error = -ENOMEM;
int i;
diff --git a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c
index 5d1ff8bbd012..f1b934c54088 100644
--- a/drivers/usb/image/mdc800.c
+++ b/drivers/usb/image/mdc800.c
@@ -431,7 +431,7 @@ static int mdc800_usb_probe (struct usb_interface *intf,
err ("probe fails -> wrong Number of Configuration");
return -ENODEV;
}
- intf_desc = &intf->altsetting[0];
+ intf_desc = intf->cur_altsetting;
if (
( intf_desc->desc.bInterfaceClass != 0xff )
@@ -469,13 +469,6 @@ static int mdc800_usb_probe (struct usb_interface *intf,
}
- usb_driver_claim_interface (&mdc800_usb_driver, intf, mdc800);
- if (usb_set_interface (dev, intf_desc->desc.bInterfaceNumber, 0) < 0)
- {
- err ("MDC800 Configuration fails.");
- return -ENODEV;
- }
-
info ("Found Mustek MDC800 on USB.");
down (&mdc800->io_lock);
@@ -551,8 +544,6 @@ static void mdc800_usb_disconnect (struct usb_interface *intf)
usb_unlink_urb (mdc800->write_urb);
usb_unlink_urb (mdc800->download_urb);
- usb_driver_release_interface (&mdc800_usb_driver, intf);
-
mdc800->dev=0;
usb_set_intfdata(intf, NULL);
}
diff --git a/drivers/usb/image/microtek.c b/drivers/usb/image/microtek.c
index e5f1a12dc2bb..19acf6221f97 100644
--- a/drivers/usb/image/microtek.c
+++ b/drivers/usb/image/microtek.c
@@ -693,7 +693,6 @@ static int mts_usb_probe(struct usb_interface *intf,
const struct usb_device_id *id)
{
int i;
- int result;
int ep_out = -1;
int ep_in_set[3]; /* this will break if we have more than three endpoints
which is why we check */
@@ -703,7 +702,7 @@ static int mts_usb_probe(struct usb_interface *intf,
struct vendor_product const* p;
struct usb_device *dev = interface_to_usbdev (intf);
- /* the altsettting 0 on the interface we're probing */
+ /* the current altsetting on the interface we're probing */
struct usb_host_interface *altsetting;
MTS_DEBUG_GOT_HERE();
@@ -724,8 +723,8 @@ static int mts_usb_probe(struct usb_interface *intf,
MTS_MESSAGE( "model %s is not known to be fully supported, reports welcome!\n",
p->name );
- /* the altsettting 0 on the interface we're probing */
- altsetting = &(intf->altsetting[0]);
+ /* the current altsetting on the interface we're probing */
+ altsetting = intf->cur_altsetting;
/* Check if the config is sane */
@@ -766,20 +765,6 @@ static int mts_usb_probe(struct usb_interface *intf,
MTS_WARNING( "couldn't find an output bulk endpoint. Bailing out.\n" );
return -ENODEV;
}
-
- result = usb_set_interface(dev, altsetting->desc.bInterfaceNumber, 0);
-
- MTS_DEBUG("usb_set_interface returned %d.\n",result);
- switch( result )
- {
- case 0: /* no error */
- break;
-
- default:
- MTS_DEBUG( "unknown error %d from usb_set_interface\n",
- (int)result );
- return -ENODEV;
- }
new_desc = kmalloc(sizeof(struct mts_desc), GFP_KERNEL);