diff options
| author | Andrew Morton <akpm@osdl.org> | 2004-05-14 05:41:08 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2004-05-14 05:41:08 -0700 |
| commit | b3dafee7dc88ed3690474512919d053eb97a281f (patch) | |
| tree | eb62bf1dcff912e10d72c18dfc6ab115d0c422df | |
| parent | 5b59eadfbf215aa20885d06ce81f263df99cc009 (diff) | |
[PATCH] Covert drivers to use msec_to_jiffies
Remove various private implementations of msecs_to_jiffies() and
jiffies_to_msecs().
There are various uppercase versions which should be consolidated.
| -rw-r--r-- | drivers/block/carmel.c | 5 | ||||
| -rw-r--r-- | drivers/block/genhd.c | 26 | ||||
| -rw-r--r-- | drivers/char/watchdog/shwdt.c | 1 | ||||
| -rw-r--r-- | drivers/net/tulip/de2104x.c | 9 | ||||
| -rw-r--r-- | include/linux/libata.h | 5 |
5 files changed, 9 insertions, 37 deletions
diff --git a/drivers/block/carmel.c b/drivers/block/carmel.c index 81819216df9f..0f9e55391868 100644 --- a/drivers/block/carmel.c +++ b/drivers/block/carmel.c @@ -438,11 +438,6 @@ static int carm_bdev_ioctl(struct inode *ino, struct file *fil, return -EOPNOTSUPP; } -static inline unsigned long msecs_to_jiffies(unsigned long msecs) -{ - return ((HZ * msecs + 999) / 1000); -} - static void msleep(unsigned long msecs) { set_current_state(TASK_UNINTERRUPTIBLE); diff --git a/drivers/block/genhd.c b/drivers/block/genhd.c index a0d7ef607b05..2c849532fb63 100644 --- a/drivers/block/genhd.c +++ b/drivers/block/genhd.c @@ -357,16 +357,6 @@ static ssize_t disk_size_read(struct gendisk * disk, char *page) return sprintf(page, "%llu\n", (unsigned long long)get_capacity(disk)); } -static inline unsigned jiffies_to_msec(unsigned jif) -{ -#if 1000 % HZ == 0 - return jif * (1000 / HZ); -#elif HZ % 1000 == 0 - return jif / (HZ / 1000); -#else - return (jif / HZ) * 1000 + (jif % HZ) * 1000 / HZ; -#endif -} static ssize_t disk_stats_read(struct gendisk * disk, char *page) { disk_round_stats(disk); @@ -377,14 +367,14 @@ static ssize_t disk_stats_read(struct gendisk * disk, char *page) "\n", disk_stat_read(disk, reads), disk_stat_read(disk, read_merges), (unsigned long long)disk_stat_read(disk, read_sectors), - jiffies_to_msec(disk_stat_read(disk, read_ticks)), + jiffies_to_msecs(disk_stat_read(disk, read_ticks)), disk_stat_read(disk, writes), disk_stat_read(disk, write_merges), (unsigned long long)disk_stat_read(disk, write_sectors), - jiffies_to_msec(disk_stat_read(disk, write_ticks)), + jiffies_to_msecs(disk_stat_read(disk, write_ticks)), disk->in_flight, - jiffies_to_msec(disk_stat_read(disk, io_ticks)), - jiffies_to_msec(disk_stat_read(disk, time_in_queue))); + jiffies_to_msecs(disk_stat_read(disk, io_ticks)), + jiffies_to_msecs(disk_stat_read(disk, time_in_queue))); } static struct disk_attribute disk_attr_dev = { .attr = {.name = "dev", .mode = S_IRUGO }, @@ -498,13 +488,13 @@ static int diskstats_show(struct seq_file *s, void *v) gp->major, n + gp->first_minor, disk_name(gp, n, buf), disk_stat_read(gp, reads), disk_stat_read(gp, read_merges), (unsigned long long)disk_stat_read(gp, read_sectors), - jiffies_to_msec(disk_stat_read(gp, read_ticks)), + jiffies_to_msecs(disk_stat_read(gp, read_ticks)), disk_stat_read(gp, writes), disk_stat_read(gp, write_merges), (unsigned long long)disk_stat_read(gp, write_sectors), - jiffies_to_msec(disk_stat_read(gp, write_ticks)), + jiffies_to_msecs(disk_stat_read(gp, write_ticks)), gp->in_flight, - jiffies_to_msec(disk_stat_read(gp, io_ticks)), - jiffies_to_msec(disk_stat_read(gp, time_in_queue))); + jiffies_to_msecs(disk_stat_read(gp, io_ticks)), + jiffies_to_msecs(disk_stat_read(gp, time_in_queue))); /* now show all non-0 size partitions of it */ for (n = 0; n < gp->minors - 1; n++) { diff --git a/drivers/char/watchdog/shwdt.c b/drivers/char/watchdog/shwdt.c index ea14405b5e67..e4c235de7dca 100644 --- a/drivers/char/watchdog/shwdt.c +++ b/drivers/char/watchdog/shwdt.c @@ -64,7 +64,6 @@ */ static int clock_division_ratio = WTCSR_CKS_4096; -#define msecs_to_jiffies(msecs) (jiffies + (HZ * msecs + 9999) / 10000) #define next_ping_period(cks) msecs_to_jiffies(cks - 4) static unsigned long shwdt_is_open; diff --git a/drivers/net/tulip/de2104x.c b/drivers/net/tulip/de2104x.c index be797b5372bd..71fc3d084166 100644 --- a/drivers/net/tulip/de2104x.c +++ b/drivers/net/tulip/de2104x.c @@ -357,13 +357,6 @@ static u16 t21041_csr14[] = { 0xFFFF, 0xF7FD, 0xF7FD, 0x6F3F, 0x6F3D, }; static u16 t21041_csr15[] = { 0x0008, 0x0006, 0x000E, 0x0008, 0x0008, }; -static inline unsigned long -msec_to_jiffies(unsigned long ms) -{ - return (((ms)*HZ+999)/1000); -} - - #define dr32(reg) readl(de->regs + (reg)) #define dw32(reg,val) writel((val), de->regs + (reg)) @@ -1216,7 +1209,7 @@ static void de_adapter_wake (struct de_private *de) /* de4x5.c delays, so we do too */ current->state = TASK_UNINTERRUPTIBLE; - schedule_timeout(msec_to_jiffies(10)); + schedule_timeout(msecs_to_jiffies(10)); } } diff --git a/include/linux/libata.h b/include/linux/libata.h index efcc745effae..a7551fae4c42 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -408,11 +408,6 @@ extern int ata_std_bios_param(struct scsi_device *sdev, extern int ata_scsi_slave_config(struct scsi_device *sdev); -static inline unsigned long msecs_to_jiffies(unsigned long msecs) -{ - return ((HZ * msecs + 999) / 1000); -} - static inline unsigned int ata_tag_valid(unsigned int tag) { return (tag < ATA_MAX_QUEUE) ? 1 : 0; |
