summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Zimmermann <tzimmermann@suse.de>2025-09-09 15:19:30 +0200
committerThomas Zimmermann <tzimmermann@suse.de>2025-09-23 15:55:16 +0200
commitb9247c4e3f70a614fe0dcfcc919ad3f3deb8dd62 (patch)
tree9490a1f96391f13d6cc79903be171321c2bc0053
parent3a33c48876bc437d149cc15e0c4b96efb14912a1 (diff)
fbdev: Make drivers depend on FB_TILEBLITTING
The option CONFIG_FB_TILEBLITTING is controlled by the user. Selecting it from drivers can lead to cyclic dependencies within the config. In fbcon, there's special handling for tile blitting, which currently cannot be disabled without first disabling the relevant fbdev drivers. Fix the Kconfig dependency to make it work. Some guidelines for using select can be found in the kernel docs at [1]. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Link: https://elixir.bootlin.com/linux/v6.16/source/Documentation/kbuild/kconfig-language.rst#L147 # [1] Acked-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20250909132047.152612-2-tzimmermann@suse.de
-rw-r--r--drivers/video/fbdev/Kconfig8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index c21484d15f0c..6cea1449b4c5 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -816,11 +816,11 @@ config FB_I810_I2C
config FB_MATROX
tristate "Matrox acceleration"
depends on FB && PCI
+ depends on FB_TILEBLITTING
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
select FB_IOMEM_FOPS
- select FB_TILEBLITTING
select FB_MACMODES if PPC_PMAC
help
Say Y here if you have a Matrox Millennium, Matrox Millennium II,
@@ -1053,11 +1053,11 @@ config FB_ATY_BACKLIGHT
config FB_S3
tristate "S3 Trio/Virge support"
depends on FB && PCI && HAS_IOPORT
+ depends on FB_TILEBLITTING
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
select FB_IOMEM_FOPS
- select FB_TILEBLITTING
select FB_SVGALIB
select VGASTATE
select FONT_8x16 if FRAMEBUFFER_CONSOLE
@@ -1258,11 +1258,11 @@ config FB_VOODOO1
config FB_VT8623
tristate "VIA VT8623 support"
depends on FB && PCI && HAS_IOPORT
+ depends on FB_TILEBLITTING
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
select FB_IOMEM_FOPS
- select FB_TILEBLITTING
select FB_SVGALIB
select VGASTATE
select FONT_8x16 if FRAMEBUFFER_CONSOLE
@@ -1296,11 +1296,11 @@ config FB_TRIDENT
config FB_ARK
tristate "ARK 2000PV support"
depends on FB && PCI && HAS_IOPORT
+ depends on FB_TILEBLITTING
select FB_CFB_FILLRECT
select FB_CFB_COPYAREA
select FB_CFB_IMAGEBLIT
select FB_IOMEM_FOPS
- select FB_TILEBLITTING
select FB_SVGALIB
select VGASTATE
select FONT_8x16 if FRAMEBUFFER_CONSOLE