summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOliver Neukum <oliver@neukum.name>2002-12-18 20:10:31 -0800
committerGreg Kroah-Hartman <greg@kroah.com>2002-12-18 20:10:31 -0800
commitc14fd5793c32d720f6576eab69bc64866ea05efc (patch)
tree901af893571fc9e6834b71ffd3303f08e8db8cb7
parent0fe734cda7c63df299f609d93b59628ee3536186 (diff)
[PATCH] USB: speedtouch possible deadlock in atm_close path
this removes the spinlocks in close, so that the synchronous unlinking is safe.
-rw-r--r--drivers/usb/misc/speedtouch.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/misc/speedtouch.c b/drivers/usb/misc/speedtouch.c
index 3456c125855b..53d09d199270 100644
--- a/drivers/usb/misc/speedtouch.c
+++ b/drivers/usb/misc/speedtouch.c
@@ -614,9 +614,7 @@ static void udsl_usb_send_data_complete (struct urb *urb, struct pt_regs *regs)
int udsl_usb_cancelsends (struct udsl_instance_data *instance, struct atm_vcc *vcc)
{
int i;
- unsigned long flags;
- spin_lock_irqsave (&instance->sndqlock, flags);
for (i = 0; i < UDSL_NUMBER_SND_URBS; i++) {
if (!instance->send_ctx[i].skb)
continue;
@@ -628,7 +626,6 @@ int udsl_usb_cancelsends (struct udsl_instance_data *instance, struct atm_vcc *v
instance->send_ctx[i].skb = NULL;
}
}
- spin_unlock_irqrestore (&instance->sndqlock, flags);
return 0;
}