diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-01-31 20:48:33 +0800 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2026-02-14 11:09:47 +0100 |
| commit | c39ee2d264f98efa14aa46c9942114cb03c7baa6 (patch) | |
| tree | f774f653697ef3eb9cf1c7a4414e3fffb207197c | |
| parent | c595c19602cea955e23b8957e109f2da26407f8d (diff) | |
fbdev: of_display_timing: Fix device node reference leak in of_get_display_timings()
Use for_each_child_of_node_scoped instead of for_each_child_of_node
to ensure automatic of_node_put on early exit paths, preventing
device node reference leak.
Fixes: cc3f414cf2e4 ("video: add of helper for display timings/videomode")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
| -rw-r--r-- | drivers/video/of_display_timing.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c index 1940c9505dd3..a6ec392253c3 100644 --- a/drivers/video/of_display_timing.c +++ b/drivers/video/of_display_timing.c @@ -195,7 +195,7 @@ struct display_timings *of_get_display_timings(const struct device_node *np) disp->num_timings = 0; disp->native_mode = 0; - for_each_child_of_node(timings_np, entry) { + for_each_child_of_node_scoped(timings_np, child) { struct display_timing *dt; int r; @@ -206,7 +206,7 @@ struct display_timings *of_get_display_timings(const struct device_node *np) goto timingfail; } - r = of_parse_display_timing(entry, dt); + r = of_parse_display_timing(child, dt); if (r) { /* * to not encourage wrong devicetrees, fail in case of @@ -218,7 +218,7 @@ struct display_timings *of_get_display_timings(const struct device_node *np) goto timingfail; } - if (native_mode == entry) + if (native_mode == child) disp->native_mode = disp->num_timings; disp->timings[disp->num_timings] = dt; |