diff options
| author | Zilin Guan <zilin@seu.edu.cn> | 2025-12-24 15:21:42 +0000 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-12-24 11:07:15 -0600 |
| commit | cb6d5aa9c0f10074f1ad056c3e2278ad2cc7ec8d (patch) | |
| tree | 0697b10bf81f9b79284665840bae715e8ac8c1c0 | |
| parent | 9448598b22c50c8a5bb77a9103e2d49f134c9578 (diff) | |
cifs: Fix memory and information leak in smb3_reconfigure()
In smb3_reconfigure(), if smb3_sync_session_ctx_passwords() fails, the
function returns immediately without freeing and erasing the newly
allocated new_password and new_password2. This causes both a memory leak
and a potential information leak.
Fix this by calling kfree_sensitive() on both password buffers before
returning in this error case.
Fixes: 0f0e357902957 ("cifs: during remount, make sure passwords are in sync")
Signed-off-by: Zilin Guan <zilin@seu.edu.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/client/fs_context.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index c2de97e4ad59..d4291d3a9a48 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -1139,6 +1139,8 @@ static int smb3_reconfigure(struct fs_context *fc) rc = smb3_sync_session_ctx_passwords(cifs_sb, ses); if (rc) { mutex_unlock(&ses->session_mutex); + kfree_sensitive(new_password); + kfree_sensitive(new_password2); return rc; } |