diff options
| author | Ganesh Varadarajan <ganesh@tuxtop.vxindia.veritas.com> | 2002-03-12 22:35:53 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <greg@kroah.com> | 2002-03-12 22:35:53 -0800 |
| commit | d348f4e3da4931258f9bacf37520b4296e765632 (patch) | |
| tree | 6a7e97a38edb51cc4b4ad42e0252d37d11bc4bb5 | |
| parent | 7776fafc393f99d8a2e64aba8723bc93ec00d569 (diff) | |
USB ipaq driver
Fixed a panic caused by the line discipline echoing characters. It
also fixes a problem where the echoing messes up ppp chat.
| -rw-r--r-- | drivers/usb/serial/ipaq.c | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c index 13e473bd7f73..c839920d236a 100644 --- a/drivers/usb/serial/ipaq.c +++ b/drivers/usb/serial/ipaq.c @@ -9,6 +9,16 @@ * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * + * (8/3/2002) ganesh + * The ipaq sometimes emits a '\0' before the CLIENT string. At this + * point of time, the ppp ldisc is not yet attached to the tty, so + * n_tty echoes "^ " to the ipaq, which messes up the chat. In 2.5.6-pre2 + * this causes a panic because echo_char() tries to sleep in interrupt + * context. + * The fix is to tell the upper layers that this is a raw device so that + * echoing is suppressed. Thanks to Lyle Lindholm for a detailed bug + * report. + * * (25/2/2002) ganesh * Added support for the HP Jornada 548 and 568. Completely untested. * Thanks to info from Heath Robinson and Arieh Davidoff. @@ -148,6 +158,8 @@ static int ipaq_open(struct usb_serial_port *port, struct file *filp) */ port->tty->low_latency = 1; + port->tty->raw = 1; + port->tty->real_raw = 1; /* * Lose the small buffers usbserial provides. Make larger ones. |