diff options
| author | Eric Dumazet <edumazet@google.com> | 2026-02-04 05:51:44 +0000 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-02-05 09:23:05 -0800 |
| commit | d5c539155431cfb93d3ea8080649ea093102a490 (patch) | |
| tree | 0313b467cf61b6435b442485758262fad8b9eb72 | |
| parent | 77dc4a72b0f1704a1e4e0ecd58a57d9e02a685c8 (diff) | |
inet: move reqsk_queue_alloc() to net/ipv4/inet_connection_sock.c
Only called once from inet_csk_listen_start(), it can be static.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260204055147.1682705-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | include/net/request_sock.h | 2 | ||||
| -rw-r--r-- | net/core/request_sock.c | 24 | ||||
| -rw-r--r-- | net/ipv4/inet_connection_sock.c | 9 |
3 files changed, 9 insertions, 26 deletions
diff --git a/include/net/request_sock.h b/include/net/request_sock.h index 9b9e04f6bb89..23bb909771fb 100644 --- a/include/net/request_sock.h +++ b/include/net/request_sock.h @@ -196,8 +196,6 @@ struct request_sock_queue { */ }; -void reqsk_queue_alloc(struct request_sock_queue *queue); - void reqsk_fastopen_remove(struct sock *sk, struct request_sock *req, bool reset); diff --git a/net/core/request_sock.c b/net/core/request_sock.c index 897a8f01a67b..31389f875b19 100644 --- a/net/core/request_sock.c +++ b/net/core/request_sock.c @@ -17,30 +17,6 @@ #include <net/request_sock.h> /* - * Maximum number of SYN_RECV sockets in queue per LISTEN socket. - * One SYN_RECV socket costs about 80bytes on a 32bit machine. - * It would be better to replace it with a global counter for all sockets - * but then some measure against one socket starving all other sockets - * would be needed. - * - * The minimum value of it is 128. Experiments with real servers show that - * it is absolutely not enough even at 100conn/sec. 256 cures most - * of problems. - * This value is adjusted to 128 for low memory machines, - * and it will increase in proportion to the memory of machine. - * Note : Dont forget somaxconn that may limit backlog too. - */ - -void reqsk_queue_alloc(struct request_sock_queue *queue) -{ - queue->fastopenq.rskq_rst_head = NULL; - queue->fastopenq.rskq_rst_tail = NULL; - queue->fastopenq.qlen = 0; - - queue->rskq_accept_head = NULL; -} - -/* * This function is called to set a Fast Open socket's "fastopen_rsk" field * to NULL when a TFO socket no longer needs to access the request_sock. * This happens only after 3WHS has been either completed or aborted (e.g., diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index 018e8ffc0717..60f2ee039c05 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -1314,6 +1314,15 @@ static int inet_ulp_can_listen(const struct sock *sk) return 0; } +static void reqsk_queue_alloc(struct request_sock_queue *queue) +{ + queue->fastopenq.rskq_rst_head = NULL; + queue->fastopenq.rskq_rst_tail = NULL; + queue->fastopenq.qlen = 0; + + queue->rskq_accept_head = NULL; +} + int inet_csk_listen_start(struct sock *sk) { struct inet_connection_sock *icsk = inet_csk(sk); |
