diff options
| author | Bartlomiej Zolnierkiewicz <bzolnier@trik.(none)> | 2004-12-30 21:00:56 +0100 |
|---|---|---|
| committer | Bartlomiej Zolnierkiewicz <bzolnier@trik.(none)> | 2004-12-30 21:00:56 +0100 |
| commit | de20380f6dbd7eb6feca7fbe666b8ef2b6b55ccf (patch) | |
| tree | d6f74eaaf0b66812c4aa372e5e499de7f0a58d19 | |
| parent | a7766f89ec2a84120fb708c03c39eb9940bc3d93 (diff) | |
[ide] it8172: incorrect return from it8172_init_one()
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Several IDE drivers return positive values as errors in the PCI setup
code. Unfortunately the PCI layer considers positive values as success
so the driver skips the device but still claims it and things then go
downhill.
This fixes the IT8172 driver.
From: Francois Romieu <romieu@fr.zoreil.com>
Use -ENODEV instead of -EAGAIN.
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
| -rw-r--r-- | drivers/ide/pci/it8172.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ide/pci/it8172.c b/drivers/ide/pci/it8172.c index 86f763dd62b7..2b57048e041f 100644 --- a/drivers/ide/pci/it8172.c +++ b/drivers/ide/pci/it8172.c @@ -270,7 +270,7 @@ static int __devinit it8172_init_one(struct pci_dev *dev, const struct pci_devic { if ((!(PCI_FUNC(dev->devfn) & 1) || (!((dev->class >> 8) == PCI_CLASS_STORAGE_IDE)))) - return 1; /* IT8172 is more than only a IDE controller */ + return -ENODEV; /* IT8172 is more than an IDE controller */ ide_setup_pci_device(dev, &it8172_chipsets[id->driver_data]); return 0; } |