summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Morton <akpm@digeo.com>2003-02-10 07:36:54 -0800
committerLinus Torvalds <torvalds@home.transmeta.com>2003-02-10 07:36:54 -0800
commite1f3b1fc6d0936fff36942c84503960ecd937abe (patch)
treeb52125382753c87fde1a7449f0dc157bc1cd5777
parentec07c5c10a251efd40afaf0117621f613118265a (diff)
[PATCH] Don't run unlock_super() in ext3_fill_super()
A very long time ago ext3_fill_super() was beng called under the VFS's lock_super(), and it had to drop that lock for deadlock avoidance reasons. But the VFS was later changed to not take lock_super() across ->fill_super(), so we're upping a non-downed semaphore. Just take it out.
-rw-r--r--fs/ext3/super.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext3/super.c b/fs/ext3/super.c
index 3f92266d6f53..765ec7d043f7 100644
--- a/fs/ext3/super.c
+++ b/fs/ext3/super.c
@@ -1343,9 +1343,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
* superblock lock.
*/
EXT3_SB(sb)->s_mount_state |= EXT3_ORPHAN_FS;
- unlock_super(sb); /* akpm: sigh */
ext3_orphan_cleanup(sb, es);
- lock_super(sb);
EXT3_SB(sb)->s_mount_state &= ~EXT3_ORPHAN_FS;
if (needs_recovery)
printk (KERN_INFO "EXT3-fs: recovery complete.\n");