summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDave Jones <davej@codemonkey.org.uk>2003-05-21 04:33:08 +0100
committerDave Jones <davej@codemonkey.org.uk>2003-05-21 04:33:08 +0100
commite8d317e4091c211ac305aa43fabb4b1b602402c9 (patch)
tree3041b3b9cf7be2f8c6e7c40a87edf06ac947929b
parent6c1c1a4774e137cac03b1c997dde3f93fbcd4e83 (diff)
[AGPGART] sanity check printk's.
-rw-r--r--drivers/char/agp/generic.c15
1 files changed, 10 insertions, 5 deletions
diff --git a/drivers/char/agp/generic.c b/drivers/char/agp/generic.c
index 62de94f71262..e311f921ffb7 100644
--- a/drivers/char/agp/generic.c
+++ b/drivers/char/agp/generic.c
@@ -311,12 +311,15 @@ EXPORT_SYMBOL(agp_copy_info);
* It returns -EINVAL if the pointer == NULL.
* It returns -EBUSY if the area of the table requested is already in use.
*/
-int agp_bind_memory(agp_memory * curr, off_t pg_start)
+int agp_bind_memory(agp_memory *curr, off_t pg_start)
{
int ret_val;
- if ((agp_bridge->type == NOT_SUPPORTED) ||
- (curr == NULL) || (curr->is_bound == TRUE)) {
+ if ((agp_bridge->type == NOT_SUPPORTED) || (curr == NULL))
+ return -EINVAL;
+
+ if (curr->is_bound == TRUE) {
+ printk (KERN_INFO PFX "memory %p is already bound!\n", curr);
return -EINVAL;
}
if (curr->is_flushed == FALSE) {
@@ -343,15 +346,17 @@ EXPORT_SYMBOL(agp_bind_memory);
* It returns -EINVAL if this piece of agp_memory is not currently bound to
* the graphics aperture translation table or if the agp_memory pointer == NULL
*/
-int agp_unbind_memory(agp_memory * curr)
+int agp_unbind_memory(agp_memory *curr)
{
int ret_val;
if ((agp_bridge->type == NOT_SUPPORTED) || (curr == NULL))
return -EINVAL;
- if (curr->is_bound != TRUE)
+ if (curr->is_bound != TRUE) {
+ printk (KERN_INFO PFX "memory %p was not bound!\n", curr);
return -EINVAL;
+ }
ret_val = agp_bridge->driver->remove_memory(curr, curr->pg_start, curr->type);