diff options
| author | Patrick McHardy <kaber@coreworks.de> | 2004-09-23 00:50:37 -0700 |
|---|---|---|
| committer | David S. Miller <davem@kernel.bkbits.net> | 2004-09-23 00:50:37 -0700 |
| commit | e92094cf37607eeaf55c53c4767235f9f412bd5f (patch) | |
| tree | 044a7d9abc2ced371cba8189f4cb1a3e98b3fb19 | |
| parent | f86c7b28768511304c76513002bcc7ee4ca3f53b (diff) | |
[NETFILTER]: Fix invalid return values in sctp_new
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv4/netfilter/ip_conntrack_proto_sctp.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/net/ipv4/netfilter/ip_conntrack_proto_sctp.c b/net/ipv4/netfilter/ip_conntrack_proto_sctp.c index 3105e2b0149b..0795e7695175 100644 --- a/net/ipv4/netfilter/ip_conntrack_proto_sctp.c +++ b/net/ipv4/netfilter/ip_conntrack_proto_sctp.c @@ -430,16 +430,16 @@ static int sctp_new(struct ip_conntrack *conntrack, DEBUGP("\n"); if (skb_copy_bits(skb, skb->nh.iph->ihl * 4, &sctph, sizeof(sctph)) != 0) - return -1; + return 0; if (do_basic_checks(conntrack, skb, map) != 0) - return -1; + return 0; /* If an OOTB packet has any of these chunks discard (Sec 8.4) */ if ((test_bit (SCTP_CID_ABORT, (void *)map)) || (test_bit (SCTP_CID_SHUTDOWN_COMPLETE, (void *)map)) || (test_bit (SCTP_CID_COOKIE_ACK, (void *)map))) { - return -1; + return 0; } newconntrack = SCTP_CONNTRACK_MAX; @@ -461,7 +461,7 @@ static int sctp_new(struct ip_conntrack *conntrack, if (skb_copy_bits(skb, offset + sizeof (sctp_chunkhdr_t), &inithdr, sizeof(inithdr)) != 0) { - return -1; + return 0; } DEBUGP("Setting vtag %x for new conn\n", @@ -471,7 +471,7 @@ static int sctp_new(struct ip_conntrack *conntrack, inithdr.init_tag; } else { /* Sec 8.5.1 (A) */ - return -1; + return 0; } } /* If it is a shutdown ack OOTB packet, we expect a return |