diff options
| author | Namjae Jeon <linkinjeon@kernel.org> | 2025-07-21 14:29:43 +0900 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2025-07-24 22:55:29 -0500 |
| commit | ecd9d6bf88ddd64e3dc7beb9a065fd5fa4714f72 (patch) | |
| tree | 8ced5e0b7bb100932aa2e089dd6648a09b82baeb | |
| parent | 9b493ab6f35178afd8d619800df9071992f715de (diff) | |
ksmbd: check return value of xa_store() in krb5_authenticate
xa_store() may fail so check its return value and return error code if
error occurred.
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/smb/server/smb2pdu.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 0caf30fb1df1..b46fbc8087e0 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -1594,7 +1594,7 @@ static int krb5_authenticate(struct ksmbd_work *work, struct ksmbd_conn *conn = work->conn; struct ksmbd_session *sess = work->sess; char *in_blob, *out_blob; - struct channel *chann = NULL; + struct channel *chann = NULL, *old; u64 prev_sess_id; int in_len, out_len; int retval; @@ -1660,7 +1660,12 @@ binding_session: return -ENOMEM; chann->conn = conn; - xa_store(&sess->ksmbd_chann_list, (long)conn, chann, KSMBD_DEFAULT_GFP); + old = xa_store(&sess->ksmbd_chann_list, (long)conn, + chann, KSMBD_DEFAULT_GFP); + if (xa_is_err(old)) { + kfree(chann); + return xa_err(old); + } } } |