summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRoger Pau Monné <roger.pau@citrix.com>2014-09-15 11:55:27 +0200
committerLuis Henriques <luis.henriques@canonical.com>2014-11-17 14:11:53 +0000
commitfea6ccb68d5f98972dea30055b6e5ee7e413036d (patch)
tree3b11e3fbd0e1f63e71a20b622285b1175fe8dabf
parent8a2a4f7127fd1b30a3bf0b640962e459977d7b94 (diff)
xen-blkback: fix leak on grant map error path
commit 61cecca865280bef4f8a9748d0a9afa5df351ac2 upstream. Fix leaking a page when a grant mapping has failed. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> Reported-and-Tested-by: Tao Chen <boby.chen@huawei.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
-rw-r--r--drivers/block/xen-blkback/blkback.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index 64c60edcdfbc..63fc7f06a014 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -763,6 +763,7 @@ again:
BUG_ON(new_map_idx >= segs_to_map);
if (unlikely(map[new_map_idx].status != 0)) {
pr_debug(DRV_PFX "invalid buffer -- could not remap it\n");
+ put_free_pages(blkif, &pages[seg_idx]->page, 1);
pages[seg_idx]->handle = BLKBACK_INVALID_HANDLE;
ret |= 1;
goto next;