diff options
| author | Sam Ravnborg <sam@ravnborg.org> | 2003-02-22 01:20:46 -0800 |
|---|---|---|
| committer | Richard Henderson <rth@kanga.twiddle.net> | 2003-02-22 01:20:46 -0800 |
| commit | 375d43ee190a01d034cdff0c4a3e5dfa94886529 (patch) | |
| tree | a5d30628a9bc26664ae9691dc81a0005e6300dc4 /arch/alpha/lib/Makefile | |
| parent | 877eec6c5f4bf36ee6afe38b575834b4d9850882 (diff) | |
[PATCH] Alpha CFLAGS fix
Hi Richard.
I noticed you have set -Werror in all alpha architecture
specific makefiles - good initiative. I wish we could do that in general.
But the correct way to alter CFLAGS in kbuild makefiles is to use
EXTRA_CFLAGS.
The following patch fixes this.
You could argue that this is a stylistic issue, but in this way
you follow Documentation/kbuild/makefiles.txt
I stumbled over:
EXTRA_AFLAGS := $(CFLAGS)
I could not realise the purpose with this assignment, and I noticed
that it did not include -Werror, becuse you did hat assignment in
the following line.
Wanted to inform you about it but I see no problem. It is just that
I did not understand it.
In math-emu I see this:
EXTRA_CFLAGS := -Iinclude/math-emu -w
Grepping the src I see no reason to have the -Iinclude/math-emu
Relevant files are prefixed with math-emu (soft-fp, single, double)
I did not fix it, because I cannot compile alpha.
Sam (the Makefile nitpicker)
===== arch/alpha/kernel/Makefile 1.24 vs edited =====
Diffstat (limited to 'arch/alpha/lib/Makefile')
| -rw-r--r-- | arch/alpha/lib/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/alpha/lib/Makefile b/arch/alpha/lib/Makefile index 8e0e2a128e9e..dd5717a27297 100644 --- a/arch/alpha/lib/Makefile +++ b/arch/alpha/lib/Makefile @@ -3,7 +3,7 @@ # EXTRA_AFLAGS := $(CFLAGS) -CFLAGS += -Werror +EXTRA_CFLAGS := -Werror L_TARGET := lib.a |
